MAMEWorld >> EmuChat
View all threads Index   Flat Mode Flat  

Buffi
MAME Fan
Reged: 07/18/21
Posts: 3
Send PM
Best way to get a MAME pull request reviewed? (Cave CV1000)
03/08/23 09:52 PM


Hey, so context is this:
https://github.com/mamedev/mame/pull/10849

Which is based on https://buffis.com/research/cv1000-blitter-research/ and https://buffis.com/research/more-cv1000-research-now-featuring-clipping/

This should be significantly closer to the Blitter delays on cv1k hardware compared to what's currently in the MAME driver. As mentioned in the PR, this doesn't fully fix slowdown in the games, but its a step in the right direction.

I think it would be pretty neat to have this merged into mainline mame, so I don't have to maintain a fork with it, but the pull request hasn't really seen much action except for Haze giving it a nod of approval late January.

I've built a binary with this included and distributed it to several people with experience with the original hardware and so far I've not heard of any issues with this update (and have heard some positive things).

I realize that this may be a complicated piece of code to review and that MAME is an enthusiast driven project, so having a PR take a long time to review is not too surprising, but would be cool to make some progress on this

What can I do to make forward momentum here?

Thanks!







Entire thread
Subject Posted by Posted on
* Best way to get a MAME pull request reviewed? (Cave CV1000) Buffi 03/08/23 09:52 PM
. * Re: Best way to get a MAME pull request reviewed? (Cave CV1000) Vas Crabb  03/08/23 10:04 PM
. * Re: Best way to get a MAME pull request reviewed? (Cave CV1000) Buffi  03/08/23 10:29 PM
. * Re: Best way to get a MAME pull request reviewed? (Cave CV1000) Vas Crabb  04/02/23 05:36 PM
. * Re: Best way to get a MAME pull request reviewed? (Cave CV1000) Buffi  04/03/23 12:18 PM

Extra information Permissions
Moderator:  Robbbert, Tafoid 
1 registered and 307 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 388