0.243

- New games: Bowmen, Cal Omega - Game 17.0 (Amusement Poker), Le Pendu (Bilingue, Version 04), Le Super Pendu (V1, words set #1) and Le Super Pendu (V1, words set #2)
- New Working games: Football Crazy (Video Quiz)
- New Non-Working games: Flying Fortress [TTL], Horses For Courses (NSW, Australia), Long Hu Tebie Ban (V101CN), Maxi Double Poker (version 1.8), Photo Play 2002 (Belgium), The Quest (NSW, Australia), Sport Damjes 1, Super 97 (Ver. 1.00) and 'Unknown darts game (487 System I)'
- New clones: Bad Lands (Modular System), Blood Storm (v2.21), Densha de GO! (Ver 2.3 J), Dragon Ninja (Modular System), Finger (bootleg of Stinger), Galaxian (Artic System bootleg), Golden Poker Double Up (bootleg, set 2), Golden Poker Double Up (bootleg, set 3), Golden Poker Double Up (bootleg, set 4), Hard Drivin' (compact, rev 2 bootleg), Indoor Soccer (Tecfri license PCB), Multi Win (EPM7032, encrypted), Multi Win (Ver.0091, encrypted), Photo Play 1999 (Netherlands), Photo Play 2000 (Netherlands), Photo Play 2001 (Netherlands), Photo Play Masters 2001 (Netherlands), Slap Fight (Modular System) and Street Fighter III 2nd Impact: Giant Attack (Hispanic 970930)
- New drivers: badlands_ms.cpp, lependu.cpp, paokaipc.cpp, slapfght_ms.cpp and spdamjes.cpp
- New devices: mc68hc11e1 and sega8_korean_188
- CPU
  . Dynamic Re-Compiling: Fixed assert in debug build with some CPUs (PowerPC, SH) (cpu\drcbex64.cpp)
  . Intel I386: Fixed multiple issues with breakpoint emulation (i386\i386.cpp, i386ops.hxx and i386segs.hxx)
  . MIPS-III: Added new DRC option to added extra validation to hash jumps. Moved unchanging conditionals outside for loop in generate_checksum_block; 7% faster (mips\mips3drc.cpp).
- SOUND
  . Atari CAGE / Atari CAGE Seattle: Added partially support of variable sound output channels (audio\cage.cpp)
  . CD Audio: Return error response when no CD is available (machine\t10mmc.cpp)
  . Discrete Sound: Explicitly initialise members of discrete "devices" to zero (sound\discrete.h). There is no way around doing this in headers due to the macro soup used to build the constructors.
  . TMS5220: Work around problem with sound CPU interrupts that was preventing PSG sounds from playing (sound\tms5220.cpp and drivers\looping.cpp)
  . Williams WPC Sound: Added save-state support (audio\wpcsnd.cpp)
- DEVICE
  . 3dfx Voodoo Graphics: Changed vsync counter to start immediately after vblank. Based on documentation of vretrace register (video\voodoo.cpp).
  . BACTA Datalogger: Prevent continuous transmission of 0xff (machine\bacta_datalogger.cpp)
  . CD-ROM
    . Classify cdrom_file. Could use more internal work, but it's a step.
    . Clean up code somewhat. Use std::string_view for filename parameters. Use ioprocs rather than core_file. Reduced commenting out of miscellaneous logging (util\cdrom.cpp).
  . CHDMAN: Optimized error return from read_metadata (util\chd.cpp)
  . Floppy
    . Removed the save support that is just too broken and member variables (formats\imd_dsk.cpp). Constify the floppy image handling interface. Removed the intermediate allocator (lib\formats\*_dsk.cpp). Changed the internal format to flux changes, updated the MFI format accordingly (keep read compatibility with the old MFI) (imagedev\floppy.cpp). Revisit the identify returns (lib\formats\*_dsk.cpp). Removed write support for now, it has issues (sharing data between read and write, copy/pasting the pll code, not supporting v3) (formats\hxchfe_dsk.cpp).
    . Changed floppy_image_device::init_fs() to set the dirty bit on the floppy image (imagedev\floppy.cpp). Note: This is not an actual user facing bug right now, because in the MAME UI the call to init_fs() is followed up by a call to setup_write(), which forces the image to commit without regard to the dirty bit.  There is an argument that this is itself code smell; setup_write() perhaps should be set_output_format() and not arbitrarily perform a commit.
    . Changed fs::meta_value::to_string() to not be static and not require meta_type. No need to pass in the meta_type when using std::visit() on the std::variant (tools\floptool.cpp and formats\fsmeta.cpp).
    . Consolidated floppy_image_device::m_create_fs and floppy_image_device::m_io_fs vectors. We had two separate members in floppy_image_device (m_create_fs and m_io_fs) that contained the same data. Whether the file systems can be formatted or read can be identified by querying fs::manager_t. For this reason, it seems bad to have these separate members, the seemingly only reason to make the UI code slightly less complicated. For this reason I consolidated these two members and moved the burden of selecting which ones are creatable to the UI code (imagedev\floppy.cpp, ui\filecreate.cpp and ui\floppycntrl.cpp).
    . Fixed some issues involving fs::meta_description constructing. With the recent change to use std::variant more closely, I noticed a problem where meta_descriptions of type meta_type::String got defaults of type 't'. This was because the templated ctor for meta_description would convert 'const char *' to 'bool'. This change added another overload to catch 'const char *', along with asserts to catch problems. In the process I corrected a few meta_description ctors. It is possible that this change does not go far enough. Perhaps the meta_type argument should be removed, and we should instead create distinct ctor types (rather than relying on templates) and specify the precise meta_type in the overload. Or even go further and remove m_type from meta_description, and instead create an overload that calculates meta_type based on calling std::visit on the variant. Taking this change a bit further, and removing m_type from fs::meta_description; it was superfluous. Also doing some minor C++-ifications (formats\fsmeta.h).
    . Added a 'type()' accessor to fs::meta_value. Let's try to hide the nastiness of std::visit() as much as humanly possible. Changing visitor approach for std::visit() call in fs::meta_value::type() (formats\fsmeta.cpp).
    . Fixed string constructor for fs::meta_value. In absence of a constructor that explicitly took 'const char *', passing a const char * would be interpretted as a bool (formats\fsmeta.h).
    . Fixed issues when wrapping in generate_bitstream_from_track which were especially damaging for (MESS) Apple drivers (formats\flopimg.cpp) (ID 07449)
  . GD-ROM: Fixed crash with no GD-ROM loaded (machine\gdrom.cpp)
  . Harddisk: Classify hard_disk_file. Hide the CHD (hard_disk_file).
  . Imagetek I4100/I4220/I4300 VDP: Added external pin callbacks and disallow internal irq acks for 5 to 7 lines. Extend external pin notes (video\imagetek_i4100.cpp).
  . MC68340 Timer Module: Fixed potential crash on mode logging (machine\68340tmu.cpp)
  . MIDI In image device: Use util::random_read rather than buffer pointer in MIDI file parser (imagedev\midiin.cpp)
  . SCSI CD-ROM: Don't crash on certain commands when no cdrom is inserted (nscsi\cd.cpp)
  . Yamaha V9938 VDP: Fixed out-of-bounds errors from invalid command writes in certain modes
  . Z80 SCC Channel
    . Fixed incorrect setting of baud rate due to uninitialised variables. Added support for WR15_ZEROCOUNT interrupts (machine\z80scc.cpp), fixes (MESS) Apple IIgs Diversi-Tune 1.1 freezes MAME (ID 08239).
    . Removed unused Z80SCC_USE_LOCAL_BRG and simplified WR15_ZEROCOUNT usage to reduce the likelihood of needless timer activation.
- 1942.cpp: Added hardware info and corrected main CPU clock
- aristmk5.cpp, ertictac.cpp and ssfindo.cpp
  . Workaround missing default QS1000 sounds in 'See See Find Out' and 'Tetris Fighters' by disabling DAC outputs for the time being (machine\acorn_vidc.cpp).
  . Improved serial DAC overrun/int handling, makes SFXs to work better in Pang Pang Car (machine\arm_iomd.cpp).
- atlantis.cpp and vegas.cpp
  . Fixed watchdog reset in nbanfl and nbagold when select other game menu from service menu (ID 07823)
  . Moved hdd set_dma_transfer into machine config for vegas.cpp
  . Added new DRC option to added extra validation to hash jumps (mips\mips3drc.cpp). Moved unchanging conditionals outside for loop in generate_checksum_block; 7% faster (mips\mips3drc.cpp).
  . Fixed screen tearing in Gauntlet Dark Legacy and Gauntlet Legends (ID 08064)
- chihiro.cpp, naomi.cpp and triforce.cpp: Use swapendian_int64 instead of custom rev64 function (machine\naomigd.cpp). Fixed crash with no GD-ROM loaded (machine\gdrom.cpp).
- cinemat.cpp: Fixed mistake in return statement (flagged by some versions of Clang, ccpu\ccpudasm.cpp)
- cosmos_playc8f.cpp: Added "SY-MUSIC01" PCB ASCII layout
- cubo.cpp: Fixed exception on start (machine\akiko.cpp)
- cv1k.cpp: Detect versions of the EP1C12 firmware (video\epic12.cpp)
- ddenlovr.cpp: Added banked NVRAM, simplified ROM loading and stop using regions for RAM for the later games: daimyojn, hanakanz, hkagerou, jongtei, kotbinsp, kotbinyo, mjchuuka, mjdchuka, mjgnight, mjreach1 and momotaro.
- fruitpc.cpp, gammagic.cpp and paokaipc.cpp: Inherit proper PCI_ROOT bus
- galaxold.cpp
  . Identified 'Cabinet' configuration, 'Coinage' and 'Award Free Game' dipswitches for clone Bulls Eye Darts (Galaxian conversion) (ID 08283). Added 82s153 PLD dump.
  . Identified 'Coin A/B', 'True or False Bonus' and 'Attract Mode' dipswitches for Trivia Challenge (ID 08285)
- gottlieb.cpp: Added save-state support for the non-laserdisc games
- hyprduel.cpp and metro.cpp
  . Added external pin callbacks and disallow internal irq acks for 5 to 7 lines. Extend external pin notes (video\imagetek_i4100.cpp).
  . Tie irq line 5 to a vblank source with external pin 0 as irq enable, fixes graphics and speed issue in karatour, karatourj, ladykill and 3kokushi (ID 08203).
  . Added note about Varia Metal layer alignments. Fixed Blazing Tornado and Grand Striker 2 regressions. Address code review.
- jaguar.cpp: Fixed nodisc crash and restore state
- ksys573.cpp
  . Workaround for segmentation fault when starting systems with fewer than two CD-ROMs
  . Improved counters and status flags (machine\k573dio.cpp and k573fpga.cpp)
- looping.cpp: Work around problem with sound CPU interrupts that was preventing PSG sounds from playing (drivers\looping.cpp and sound\tms5220.cpp) (ID 08289)
- m92.cpp: Only use 'palette bank' on the later games with ROM banking. This fixes R-Type Leo did not flicker between two colors during the invulnerability phase at the beginning of the game or when dying (ID 03289). Initialized a few members (video\m92.cpp). Note: There is a further test case with R-Type Leo. The flickering invulnerability effect when you spawn does not work correctly with the palette bank hooked up, and also causes a 2nd player spawning in to have the incorrect palette at first. It appears that the only games requiring the palette bank logic are Major Title 2, Ninja Baseball Bat Man, Dream Soccer '94 and Gun Force 2. These are also the games with the extended ROM banking, suggesting a difference on those boards is a more likely explanation.
- model2.cpp: Fixed crash in debug build
- nss.cpp, sfcbox.cpp and snesb.cpp: Fixed JSR being a cycle short (g65816\g65816op.h). Properly calculate page crossing penalty cycle for Y addressing modes (g65816\g65816.cpp).
- nwk-tr.cpp: Fixed crashes on start
- royalmah.cpp: Fixed memory_bank::set_entry exception in debug build for mjtensin, mjvegasa and mjvegas
- seattle.cpp
  . Fixed Hyperdrive randomly freezes (ID 07568)
  . Changed interrupt handler to not send new interrupts if an interrupt has already been asserted and improve DMA timing (machine\gt64xxx.cpp)
  . Added some harddrive dma delay to make harddrive performance more realistic. Moved hdd set_dma_transfer into machine config.
  . Fixed calibration failure regression in San Francisco Rush and San Francisco Rush: The Rock
- stv.cpp: Be a little more robust to not having any cdrom reader (machine\stvcd.cpp)
- twinkle.cpp: Implemented commands required for Twinkle DVD player (JVC XV-D701; rs232\xvd701.cpp)
- vigilant.cpp: Clean-up, no functional changes.
- viper.cpp: Use normal vsync polarity
- AGEMAME: Tidied up the test views in some more fruit machine layouts (m5gdrag, m5ggems20, m5gimmie, m5grush, m5grush5, m5gsstrk07, m5gstrik and m5hellrz)
- Big Karnak: Verify clocks
- Black Tiger (Modular System) and Slap Fight (Modular System): Fixed out-of-range access warning in some GCC versions. The implicit conversion from size_t to int could theoretically produce a negative value, which triggered a warning on the memcpy.
- Contra: Added hardware infos
- Daioh: Used correct gfx3 rom for clone Daioh (prototype, earlier), fixes various GFX glitches. Fixed incorrect 'Bonus Life' dipswitch options in clone Daioh (prototype, earlier). 
- Double Dragon II: Updated 'Timer' dipswitch naming for parent and clone (Japan) (ID 08276)
- The End: Correct DIP switches for clone Take Off (bootleg of The End) (ID 08286)
- Evil Night: Fixed clone Evil Night (ver EAA) crash at start 
- Football Crazy (Video Quiz): Added CD-ROM. Promoted game to working. Fixes game crash about 8 seconds into startup (ID 05533). I486: Fixed multiple issues with breakpoint emulation (i386\i386.cpp, i386ops.hxx and i386segs.hxx). NCR 53C7xx SCSI CPU: DFE bit is not reset when status register is read (machine\53c7xx.cpp). Zilog Z85C30 SCC: Fixed incorrect setting of baud rate due to uninitialised variables (machine\z80scc.cpp). Prevent continuous transmission of 0xff (machine\bacta_datalogger.cpp).
- Fun World Quiz (German), (German, 12-11-1990) and (German, 27-04-1990): Dumped and added the missing Geo3 questions bank ROM. Rearranged the remaining banks accordingly.
- Game Magic: Removed unused legacy PCI hookup and demoted Game Magic and clone 99 Bottles of Beer with BAD_DUMPs. Discover that removing data track pregaps makes CD-ROM dumps to be mountable.
- GameCristal: Added extend notes over dump analysis
- Go Go Strike: Split game into own driver and removed legacy PCI header defined.
- Kyros: Corrected comment and clocks
- PinMAME
  . Indicate save-state availability for all pinball drivers. Merged s8a.cpp driver into s8.cpp. Moved Rat Race from S9 to S8 driver. Game is now playable.
  . Use finder instead of tag lookup for memory bank in whitestar.cpp. Williams WPC Sound: Added save-state support (audio\wpcsnd.cpp).
- The Pit: Corrected 'Coinage' DIP switch settings for The Pit. Identified dipswitches 'Coinage', 'Game Speed' and 'Time Limit' for clone The Pit (bootleg on Moon Quasar hardware) (ID 08280).
- Pocket Racer: Decrease analog controls range
- Power Instinct: Correct one sprite rom for clone Power Instinct (USA, bootleg set 3)
- Space Invaders: Added 'Difficulty' dipswitch to clones Super Invaders (Zenitone-Microsec) and Space Attack II (bootleg of Super Invaders)
- Space Zap: Added 'Lives' dipswitch (ID 08274)
- The Speed Rumbler: Connect YM2203 irq to soundcpu
- SunA Quiz 6000 Academy: Fixed MAME crashes when answering the quiz (Fatal error: memory_bank::set_entry) (ID 08297)
- T.V. 21 III: Dumped 2 more chips
- Time Traveler: Fixed 'Very Difficult' dipswitch. Be paranoid about minimum size of unsigned (machine\ldv4200hle.cpp)
- US AAF Mustang: Fixed clone US AAF Mustang (Lettering bootleg) crashes MAME (ID 08294)
- Vendetta: Added brute-forced PLD dumps to Vendetta and clones. Added notes for clone Vendetta (World, 2 Players, ver. W).
- Wink: Identified several dipswitches for Wink and clone (ID 08284)
- Renamed (bloodstm10) to (bloodstm104), (bloodstm11) to (bloodstm110), (bloodstm21) to (bloodstm210), (bloodstm22) to (bloodstm220), (dendego) to (dendegoa) and (unkigs) to (cpoker2)
- Dipswitch fixes in 8080bw.cpp, astrocde.cpp, ddragon.cpp, galaxian.cpp, galaxold.cpp, igs017.cpp, rastersp.cpp, seta.cpp, tbowl.cpp, timetrv.cpp, thepit.cpp and wink.cpp
- Description changes of Centaur (Inder) (set 1), Centaur (Inder) (set 2), Champion Poker 2 (V100A), Gals Panic (unprotected), Gals Panic (ULA protected, set 1), Gals Panic (ULA protected, set 2), Golden Poker Double Up (bootleg, set 1), GTI Club: Rally Cote D'Azur (ver EAA), GTI Club: Rally Cote D'Azur (ver AAA), GTI Club: Rally Cote D'Azur (ver JAA), GTI Club: Rally Cote D'Azur (ver UAA), The Lost World: Jurassic Park (Japan, Revision A), The Lost World: Jurassic Park (location test), The Lost World: Jurassic Park (Pinball, 2.02), The Lost World: Jurassic Park (Pinball, 2.00), Photo Play 1998 (Spain), Photo Play 1999 (Spain), Photo Play 2000 (Spain), Photo Play 2001 (Italy), Space Attack (bootleg of Space Invaders, 2k roms), Space Attack (bootleg of Space Invaders, bproms), Space Invaders Part Four (bootleg of Space Attack II), Shuzi Leyuan (China, V127M, gambling), Starhawk, War: Final Assault (EPROM 1.9 Mar 25 1999, GUTS 1.3 Apr 20 1999, GAME Apr 20 1999), War: Final Assault (EPROM 1.3 Apr 7 1999, GUTS 1.3 Apr 7 1999, GAME Apr 7 1999), War: Final Assault (EPROM 1.6 Jan 14 1999, GUTS 1.1 Mar 16 1999, GAME Mar 16 1999) and War: Final Assault (EPROM 1.91 Apr 13 1999, GUTS 1.3 Apr 7 1999, GAME Apr 7 1999) (ID 08298).
- MAME
  . VIDEO RENDERING SYSTEM
    . Draw until current hpos (not inclusive) when doing an update_now (emu\screen.cpp and emu\video.cpp)
    . Removed some custom GFX decodes in favor of the ones provided in video\generic.cpp (various drivers)
    . Use set_clock(x) instead of m_clock=x (emu\screen.h)
  . MEMORY SYSTEM: Reduced make_unique_clear to a single variant for POD arrays (util\corealloc.h)
  . DEVICES: Don't pre-clear memory for drivers (emu\device.h). Ivan Vangelista fixed at least the majority of things that crashed outright and Robbbert initialised variables that Coverity complained about. It's unlikely anything will break due to this.
  . LUA engine: Made I/O port manager type_seq a bit more tolerant of omitted arguments (mame\luaengine_input.cpp)
  . UI
    . Respect clicks on headings (ui\datmenu.cpp)
    . Added an 'image_display_enabled' property to mame_ui_manager and exposed it to LUA. This property allows one to disable image-specific UI displays (mame\luaengine.cpp, ui\ui.cpp).
  . File handling cleanup
    . Removed fgetc, fgets and ptr methods from device_image_interface. Removed the core_file::buffer method to read an entire file into memory and rewrite emu_file::hashes to not depend on it.
    . Make core_in_memory_file a final class; now that buffering is gone, core_osd_file no longer subclasses it but a new superclass that retains some common methods.
    . Renamed the offset and length methods used internally in core_file implementations to index and size due to frequent clashes with parameter names.
    . Converted comments in util/corefile.cpp to C++ style. Added a new overload of the hash_collection::compute method which hashes data from a random_read stream, reading it into memory one chunk at a time. As a result, the hash_collection::begin and hash_collection::end methods have been removed as obsolete (similar methods are now used internally only).
    . Enhanced error messages for the frontend media identifier when it encounters file errors.
  . Make a couple of overloads const (osd\modules\osdhelper.h)
  . Use finders and some other small cleanups (ajax.cpp, angelkds.cpp, bottom9.cpp, buggychl.cpp, cbasebal.cpp, contra.cpp, crgolf.cpp, epos.cpp, exzisus.cpp, galpanic.cpp, goal92.cpp, gng.cpp, hcastle.cpp, hexion.cpp, himesiki.cpp, kangaroo.cpp, ksayakyu.cpp, labyrunr.cpp, parodius.cpp, pcktgal.cpp, shisen.cpp, skykid.cpp, spdodgeb.cpp, surpratk.cpp, tbowl.cpp and vendetta.cpp)
  . 3rdparty: Updated zlib to version 1.2.12
  . Multi-Language: Added Ukrainian UI translation. Updated simplified Chinese and Greek translation for autofire button name format.
- Compiling
  . Init variables for Coverity software (drivers, machine, video, audio, devices, bus and includes)
    . Revert initialisation of device members in headers. This is problematic in several ways: Initialising things at construction that aren't needed until after start slows down -romident, -validate, -listxml, etc. Slot cards can be a particular drain on -listxml and -validate as they're instantiated for every compatible slot. It's more pronounced for array members, too. Splitting member initialisation between declaration in headers and constructors in source files means you have to look at two places to check for the initial value, and you always need to check the constructor even if an initialiser is present in the header because the constructor initaliser list takes precedence. (This isn't as much of an issue for driver classes because the constructor is most often inlined at declaration, so it isn't far from the member declarations). Initialisers in headers for frequently-used devices increases the frequency of recompiling dependent devices/drivers as they're exposed to any changes in initialisers. Initialisers in frequently-used headers increase build times because there's more for the compiler to parse/cache (This affects makedep.py as well for single-driver builds, but that's a single pass). It's not a lot individually, but it adds up given the size of MAME, which keeps increasing.
    . Try to work around the uninitialised member warning in sol::optional (mame\luaengine.ipp, luaengine_debug.cpp and luaengine_mem.cpp)
    . Initialized some variables which were causing problems (sound\discrete.cpp)
    . Fixed Coverity software error (acefruit.cpp, chinagat.cpp, queen.cpp, royalmah.cpp). Init variables, fixed Coverity error and use standard variable names (cps1.cpp). Fixed Coverity software buffer overflow (machine\315-5838_317-0229_comp.h).
    . Init cleanups (cpu\mn10200\mn10200.cpp and cpu\psx\psx.cpp). Init 2 more variables (machine\cat702.cpp).
  . Enabled GCC lifetime dead store elimination optimisation. Note: Disabled for GCC 9, otherwise takes issue with Sol's get >() (scripts\genie.lua).
  . Fixed DRVNOCLEAR build issues (namcos22.cpp)
  . Added multibyte check to osd_uchar_from_osdchar to fix decoding ASCII text (osd\strconv.cpp). Note: This allows ASCII INI files to be parsed on Windows systems set to use a double-byte code page. It should also work with correctly-encoded Shift-JIS, GB2312, Big5 and EUC-KR. It won't work for more complex variable-length encodings or when the input is not correctly encoded.
  . Replaced a couple of static_cast with dynamic_cast for safety, cleaned up some formatting (drivers\seattle.cpp and vegas.cpp).
- Debugger
  . Debugger feature improvements: Added 'gbt' and 'gbf' debugger commands to step until a true or false conditional branch has been detected. Updated over 100 of the disassemblers in MAME to output a new STEP_COND flag for all conditional branches. Besides being used for execution of the new 'gbt' and 'gbf' commands, this flag also now helps the debugger 'out' command to properly handle conditional return instructions. Removed STEP_OVER from many instructions that aren't actually subroutine calls (e.g. DJNZ on Z80). A 'gni' debugger command (go next instruction) has been added to accommodate some of the misuse. Added instruction flag support to several more disassemblers that lacked them entirely (e.g. st62xx). Don't pass over delay slots for debugging in ASAP core.
  . Removed obsolete debugger.h include from devices\cpu\* files