MAMEWorld >> EmuChat
Previous thread Previous  View all threads Index   Next thread Next   Flat Mode Flat  

MooglyGuy
Renegade MAME Dev
Reged: 09/01/05
Posts: 2260
Send PM
Re: UPDATE- - Problem Solved!
11/30/21 04:27 AM


> I'm wondering if it's just not save-state friendly, or if F3 resets break the
> protection state.

Both, probably. m_protection_result doesn't appear to be saved anywhere in either the driver nor any derived classes. Plus m_protection_state only seems to be saved by zac_scorpion_state::init_scorpion, which isn't (and can't be) called by galaxian_state::init_theend. Neither member is initialized in any constructor or derived constructor.

So for theend at least, DOR seems to just be getting lucky that both pieces of data are being initialized to a "good" state, loading a savestate will certainly not restore whatever values they had when saving, and in either case, resetting using F3 will probably not result in either value being valid for power-on.

What's particualrly baffling is that all of the drivers in galaxian.cpp seem to be marked with MACHINE_SUPPORTS_SAVE, when they pretty clearly haven't been vetted for all used driver members being registered for saving. Either that or any members that have been added since they were marked as such haven't been added to the registration list.







Entire thread
Subject Posted by Posted on
* Will the ROM of Stern "The End" get fixed someday? DOR 09/03/20 10:46 AM
. * UPDATE- - Problem Solved! DOR  11/25/21 06:47 PM
. * Re: UPDATE- - Problem Solved! Haze  11/25/21 10:04 PM
. * Re: UPDATE- - Problem Solved! gregf  11/25/21 10:41 PM
. * Re: UPDATE- - Problem Solved! DOR  11/27/21 01:15 PM
. * Re: UPDATE- - Problem Solved! gregf  11/29/21 11:21 AM
. * Re: UPDATE- - Problem Solved! Haze  11/29/21 01:20 PM
. * Re: UPDATE- - Problem Solved! MooglyGuy  11/30/21 04:27 AM
. * Re: UPDATE- - Problem Solved! DOR  11/29/21 11:57 AM
. * Re: UPDATE- - Problem Solved! DOR  11/25/21 10:32 PM
. * Re: UPDATE- - Problem Solved! gregf  11/25/21 11:07 PM
. * Re: Will the ROM of Stern "The End" get fixed someday? RaspBear  03/22/21 09:05 PM
. * Re: Will the ROM of Stern "The End" get fixed someday? Haze  09/05/20 01:26 AM
. * Re: Will the ROM of Stern "The End" get fixed someday? DOR  09/05/20 01:56 AM
. * Re: will Stern's "The End" get fixed someday? gregf  09/05/20 03:10 PM
. * Re: Will the ROM of Stern "The End" get fixed someday? Hydreigon  09/05/20 07:16 AM
. * Re: Will the ROM of Stern "The End" get fixed someday? Haze  09/12/20 08:16 PM
. * Re: Will the ROM of Stern "The End" get fixed someday? DOR  09/05/20 10:20 AM
. * It depends MooglyGuy  09/03/20 01:26 PM
. * Re: It depends DOR  09/03/20 02:41 PM
. * Re: It depends RaspBear  09/16/20 09:00 PM
. * Re: It depends DOR  12/03/21 01:15 AM
. * Re: It depends RaspBear  12/03/21 01:19 AM
. * Re: It depends DOR  09/18/20 02:01 AM
. * Re: It depends RaspBear  09/18/20 09:24 AM
. * Re: It depends MooglyGuy  09/03/20 03:19 PM
. * Re: It depends DOR  09/03/20 03:39 PM
. * Re: It depends Roberto Fresca  09/04/20 01:02 PM
. * Re: It depends DOR  09/04/20 11:27 PM
. * Re: It depends Moochieone  09/03/20 05:45 PM
. * Re: It depends DOR  09/03/20 05:53 PM
. * Re: It depends RobbbertModerator  09/03/20 05:14 PM
. * Re: It depends DOR  09/03/20 05:41 PM
. * Re: It depends Envisaged0ne  09/05/20 01:05 AM
. * Re: It depends DOR  09/05/20 01:19 AM
. * Re: It depends Moochieone  09/05/20 04:29 AM
. * Re: It depends gregf  09/05/20 03:21 PM
. * Re: It depends TrevEB  09/06/20 09:33 PM
. * Re: It depends DOR  09/07/20 10:24 AM

Extra information Permissions
Moderator:  Robbbert, Tafoid 
0 registered and 407 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 2115