|
Re: Arkanoid sound pitch 2x higher as of 0.184
06/12/17 04:42 AM
|
|
|
Fixed in git commit 96ed3869ff8461670a940a0ef4cc3e0274938a29 for the next release (0.187).
This bug was caused by commit 0d23c0f6ea771f54a367861f379f6e7ca62d1ced back in March, which added a device_clock_changed() override. If a sound core has a device_clock_changed() override, MAME will call that function during the device init lifecycle phase, after device_init is called. ay8910.cpp only actually checked the YM2149_PIN26_LOW state during device_init, and did not check it when device_clock_changed() was called, meaning the clock speed on arkanoid was first (correctly) set to 1.5MHz, then immediately afterward as soon as device_clock_changed() is called, was set incorrectly to 3MHz. Now YM2149_PIN26_LOW is respected (as needed) during both device_init() and device_clock_changed().
The issue where the 'Tayto' copyrighted 'arkatayt' bootleg set is supposed to have a 3MHz 'overclocked' AY-3-8910A (instead of a ym2149, hence it lacks the ym2149's clock divider) still stands, though, but really should have its own mametesters ticket. I might be able to fix that anyway, though, but I'm not sure exactly which of the bootleg sets are supposed to have the sound chip clocked too fast and which ones are not.
LN
"When life gives you zombies... *CHA-CHIK!* ...you make zombie-ade!"
|
|