|
|
Re: PreTestBuild : MAME 0.171 support New Command List (include binary)
03/24/16 10:30 AM
|
|
|
First of all, your changes aren't against the latest MAME source. Several areas you've changed are very different in mainline MAME and your changes won't apply cleanly.
The code quality is bad. For example your strtrimcarriage function modifies a string passed by reference and returns a copy of that same modified string. This is horribly inefficient and wasteful, besides being useless semantics.
Your new overload of core_fgets is poorly implemented besides not applying cleanly.
I don't see the motivation for changing the magic character sequences the UI code recognises. It's doesn't achieve anything.
We handle UTF-8 and UTF-16 encodings at core_file level - why do you see a need to change emu_file, which is largely a wrapper, to add another kind of Unicode text support?
In short, these changes will never be accepted in this form.
|
|
Index 
Flat 
Re: PreTestBuild : MAME 0.171 support New Command List (include binary)
Reply
PreTestBuild : MAME 0.171 support New Command List (include binary)
