> I guess someone else will have to fix it up, as the author kept marking conversations
> as resolved when they were not, kept insisting on doing things the wrong way,
I am the author, I fixed them myself.
It was my first PR to Mame, with no guidance on the undocumented PR process whatsoever; so I wrongly thought that resolving the comments was the way to go when someone handed me what it looked like an optional suggestion. My bad.
>kept insisting on doing things the wrong way, and
> after having it pointed out to him, the stereotypical Italian machismo gear kicked
> in.
My bad as well. Also, please, please, please, fix your stereotypes. Having spent basically all my professional life in the US, it should be American machismo. At the end the PR was merged, with big help and lots of suggestions from Vas while you were commenting from the side.
>
> It probably didn't help when Simzy the Idiot Wonder-Boy stepped in and started trying
> to tell the pull request author what a "good job" he was doing, when in reality he
> was doing a pretty lousy job in terms of doubling down on incorrectness.
Before my PR sound was not working. When I proposed my changes, sound was working although not up to undocumented coding standard. Doesn't qualify as lousy job, right?
I cannot comment on other people's behavior or intentions.
My currency is "show me your code/work/contribution".
Wrt, but not directed to Vas:
> There are only really two major issues, and neither is insurmountable.
P.S. still working on it, trying to address the last issue standing between current status and having this marked as complete. https://github.com/mamedev/mame/pull/12180
You can see how much effort, research, pride and time I put in this small PR project.
|
Previous 
Index 
Next 
Flat 
Re: Model Racing Dribbling audio in the works
Reply
