0.248

- New games: Conquest (prototype)
- New Non-Working games: Acchi Muite Hoi Battle, Docchi Fighter, Exciting Speed Hockey (V19930325), Mogu Mogu Hammer, Paradise (Industrias Brasilerias, Version 1.04), Sala Due (Version 3.04), Super Mario Bros. 3 (NES bootleg) and Zoomania (Version 10.04, set 1)
- New clones: Dance Dance Revolution 2nd Mix - Link Ver (GE885 VER. JAC), Dance Maniax (G*874 VER. AAA), DrumMania 9th Mix (G*D09 VER. JAB), DrumMania 9th Mix eAmusement (G*D09 VER. JCA), DrumMania 10th Mix eAmusement (G*D40 VER. JCA), Golden Tee Golf (Trackball, v2.1), Guitar Freaks 5th Mix (G*A26 VER. AAA), Guitar Freaks 11th Mix eAmusement (G*D39 VER. JBA), Percussion Freaks 9th Mix (G*D09 VER. AAA), Percussion Freaks 10th Mix (G*D40 VER. AAA), Sala Due (Version 1.04), Soul Calibur (Asia, SOC12/VER.A2), Strikers 1945 III (World) / Strikers 1999 (Japan) (bootleg), Virtua Golf / Dynamic Golf (prototype) and Zoomania (Version 10.04, set 2)
- New PinMAME games: 'Maverick, The Movie (2.00)' and 'Red and Ted's Road Show (PA-2 prototype)'
- Removed games: San Francisco Rush (boot rom L 1.06A)
- New drivers: amuzy.cpp, eshockey.cpp, nes_arcade_bl.cpp and sraider.cpp
- New devices: apu2a03, macronix_29f008tc, nes_sharpcass and rp2a03
- CPU
  . Hyperstone E1-xxxx: E132XS cleanups: Use count_leading_zeros_32 instead of loop for TESTLZ. Simplify overflow mask calculation for SHL(I).
  . Intel I486 CPU: Use swapendian_int32 (i386\i486ops.hxx)
  . NEC uPD7810: Don't change carry flag with inr/dcr opcodes. Still affect HC flag. Refresh port C on MCC related output changes. Some variables were missing from savestates.
  . Mitsubishi M37450: M740 fixes. Only access data memory in indirect modes (m6502\m740.cpp).
  . MOS Technology 6502: Do not overwrite the variable with the access address on a read in case we want to rerun it. Added the missing uses_custom_memory_interface. Avoid multiple instructions on one line for when reads at restartable.
  . Sony CXD8xxxx: Initialise some DMA channel registers on reset, fixes (MESS) PlayStation Game Booster port peripheral no longer functions (ID 08407) (cpu\psx\dma.cpp). Without this, booting a parallel port device jumps into the weeds. Actual DMA channel state on reset needs to be investigated [Vas Crabb].
  . Zilog Z80: Fixed WZ flag
- SOUND
  . Ensoniq ES5503: More correct behavior in some swap-mode corner cases
  . Ricoh N2A03 + RP2A03 APU: Added earliest hardware variant of 2A03 APU (found in punchout, spnchout, dkong3, VS. systems and some early Famicoms). It's estimated that these letterless CPU versions are in the first two million or so Famicoms (about 10% of Famicoms sold). There are games developed on the RP2A03 that have sound glitches on later, more common Famicoms. For instance, the very last note in the game over melody in Balloon Fight rings out with a loud buzz on later machines. The new famicomo driver plays it as the developers must have intended.
- DEVICE
  . Floppy
    . Fixed use-after-std::move() issue in constructor (formats\fs_fat.cpp)
    . Changed fs::manager_t::enumerate_f() to simplify logic within file system drivers. enumerate_f() used to contain quite a bit of boilerplate logic to determine whether a particular floppy type should be added. This change attempts to move this logic outside the file system drivers to simplify the drivers. The riskiest part of this change is unformatted_image::enumerate_f(). I attempted to replicate the logic that was previously determining with unformatted image types to use, but the logic is tricky and it isn't clear to me that replicating the logic is the correct action - I may be cargo culting. * Fix to floppy_image_device::fs_enum::add_raw(). * Updating FS_FAT to reflect this PR. * On the advise of Sarayan, I moved the filtering to the fs::manager_t::fs_enum base class. This is actually a less intrusive change than what I originally had because it keeps the unformatted raw image handling closer to what we had previously. Some misgivings about these changes: 1. We now have fs::manager_t::fs_enum::add() being a thin call that invokes a protected method called fs::manager_t::fs_enum::add_format(). Better ideas for names are welcome. 2. It feels odd that we've removed the need to do filtering from the various FS modules, but the unformatted module has to ask the fs_enum() for its internal variables for filtering to perform the same logic. This seems to be the least worst option. Feedback is welcome (formats\fsmgr.cpp, tools\image_handler.cpp, imagedev\floppy.cpp).
- aleck64.cpp: Fixed stack buffer overflow (nintendo\n64_v.cpp)
- atarisy1.cpp, atarisy2.cpp, gauntlet.cpp and starwars.cpp: Re-added boost interleave on soundlatch write, fixes random occasional graphics corruption in Road Blasters (ID 07855).
- bfm_sc2.cpp: Fixed upd7759 sample triggering and reset control (ID 08325). Made the volume ramp a little less aggressive.
- docastle.cpp: Updated notes
- highvdeo.cpp: Got rid of function statics, made some sets to boot and set some to the correct machine type so the video renders as it should. Use a more obvious pixel loop with fewer tests and cleaned up spacing.
- ladybug.cpp and sraider.cpp: Put sraider driver and ladybug_video device in their own files.
- oneshot.cpp: Fixed unsigned comparison to zero bugs
- seattle.cpp
  . Added newer BIOS for NFL Blitz
  . Added San Francisco Rush Boot Code Version L1.12 as a BIOS option. Turned San Francisco Rush Boot Code Version L1.06A into a BIOS option rather than a clone - the game version is the same.
- speedbsk.cpp: Added sound banking
- vsnes.cpp
  . Added earliest hardware variant of 2A03 APU. Fixes several audio bugs with the noise channel in VS. System games, including: High-pitch sound in Vs. Gumshoe percussion track. Jet sounds in Vs. Raid on Bungeling Bay. Number of tanks killed count screen in Vs. Battle City. Vs. Platoon's bullet and enemies dying sounds are subtly changed.
  . Correct bnglngby 'Lives' dipswitch settings and added 'Difficulty' dipswitch settings. Correct supxevs 'Bonus Life' dipswitch settings and added 'Hidden Password Screen' dipswitch settings. Correct 'Lives' dipswitch settings for jajamaru.
- zerohour.cpp
  . Red Clash: Added white background and preliminary sound. Bullet width is software controlled. Added player shoot sample and minimal beeper frequency. Fixed stuck sound on highscore screen.
  . Zero Hour: Added Samples sound. Correct score panel colors. Removed imperfect gfx flag. Bullet width is software controlled. Added 1bit DAC.
  . Moved the star generator to its own file (universal\zerohour_stars.cpp) (driver now doesn't weirdly include ladybug_v anymore). Note: These functions emulate the star generator board. All this comes from the schematics for Zero Hour. It has a 17-bit LFSR which has a period of 2^17-1 clocks (one pixel shy of "two screens" worth). So, there are two starfields drawn on alternate frames. These will scroll at a rate controlled by the speed register. Renamed redclash driver to zerohour. Put driver into a single file.
- Air Buster: Added 'Kaneko CALC Hitbox' collision/protection device
- Arm Wrestling, Punch-Out!!, Donkey Kong 3 and Super Punch-Out!!: Added earliest hardware variant of 2A03 APU
- Cobra: The Arcade: Redumped DVD
- Cosmic Alien and Tournament Arkanoid: Fixed some incorrect rom locations and labels in clones Cosmic Alien (early version II?) and Tournament Arkanoid (US, newer), added some notes and mark an existing dump as good based on a redump.
- Embargo: Removed input tag lookups
- Get A Way: Improved colors and added DIP locations
- Oli-Boo-Chu: Improved AY-3-8910 sound. Added HC-55516 speech sound and confsetting for the palette.
- Ozma Wars: Added preliminary samples to replace the incorrect Invaders ones (ID 07173). Confirmed Ozma Wars has 2 SN76477.
- Percussion Freaks 9th Mix: Added missing multisession CD-ROM to clone DrumMania 9th Mix (G*D09 VER. JAA)
- San Francisco Rush 2049: Special Edition: Removed bad dump flag from rom U27. The POST checksum failure for the boot ROM was normal for this game.
- Super Pinball Action: Fixed some dips for clone Super Pinball Action (US, prototype, dual screen)
- Teenage Mutant Ninja Turtles - Mutant Warriors: Identified sblast2ba as actually being Teenage Mutant Ninja Turtles - Mutant Warriors [Dox]. Decrypted it [iq_132]. Still doesn't work, possibly because of additional protection.
- Top Roller: Added safety cliprect mask (nichibutsu\cclimber_v.cpp)
- Fixed rom names in arkanoid.cpp, cosmic.cpp, itech8.cpp and markham.cpp
- Dipswitch fixes in getaway.cpp, highvdeo.cpp, olibochu.cpp, seattle.cpp, thief.cpp and vsnes.cpp
- Description changes of Bubbles (prototype), Coccinelle (bootleg of Lady Bug), Hoccer (earlier), Hoccer (newer), Jurassic Park (USA 5.01, display G5.01), Lady Bug (bootleg), No Fear: Dangerous Sports (1.0F), Maverick, The Movie (4.04, Display Rev. 4.02), Maverick, The Movie (1.00), Maverick, The Movie (Display Rev. 4.00), Maverick, The Movie (4.02, Display Rev. 4.01), San Francisco Rush and Zero Hour (bootleg), Shadow Force - Henshin Ninja (Japan, Version 2), Sonic Blast Man II Special Turbo (SNES bootleg) and Teenage Mutant Ninja Turtles - Mutant Warriors (SNES bootleg)
- Renamed (ddr2mla) to (ddr2mlb), (ddr2ml) to (ddr2mla), (drmn9m) to (drmn9ma), (gtgt) to (gtgt20), (gtgt1) to (gtgt10), (nf_10) to (nf_10f), (pcnfrk10m) to (pcnfrk10ma), (pcnfrk9m) to (pcnfrk9ma) and (sblast2ba) to (tmntmwb)
- MAME
  . VIDEO RENDERING SYSTEM
    . Fixed wrapping constructors for indexed bitmaps taking the wrong parameter type (nothing was using them before) (util\bitmap.h). Fixed potential use-after-free issues with bitmap palettes (util\bitmap.cpp).
    . Make flipscreen setters compatible with writeline (emu\driver.cpp) (ladybug.cpp, sraider.cpp and zerohour.cpp)
    . Added a space before %FPS in speed text (emu\video.cpp)
    . Removed obsolete sample layout files (bgfx\layouts\sample\horizontal\default.lay and vertical\default.lay) and updated documentation
  . MEMORY SYSTEM
    . Added the bank tag to a fatal error message where it was missing (emu\emumem.cpp).
  . UI
    . OSD/network interface cleanup: Moved osd_midi_device from osdcore.h to osdepend.h. Moved osd_list_network_adapters from osdcore.h to osdnet.h (was already defineduniquely in osdnet.cpp). Moved #include  from osdcore.h to emu.h. Removed dinetwork.h from emu.h.
    . Added an option to copy input device IDs to the relevant menus. Added an item for setting the software lists files path (-hashpath) to the folder setup menu. Allow pasting text from clipboard in most places that allow typing (searching, entering filenames and entering barcodes). Changed the software selection menu heading to be a bit less misleading. Made barcode menu less eager to rebuild itself unnecessarily and removed some confusing and apparently pointless code.
    . Added some functionality to OSD and cleaned up a little: Added a function for copying text to the clipboard. Moved function for converting Windows error codes to standard error conditions to winutil.cpp so it can be used from more places. Removed duplicate declaration of osd_get_clipboard_text and made the function noexcept (including fixing implementations). Made macOS implementation of osd_get_clipboard_text skip the encoding conversion if it finds UTF-8 text first. Changed the default -uimodekey setting so it doesn't lose the "not shift" that stops the default from interfering with UI paste.
  . INPUT
    . Log 1-based device numbers, matching what's shown in the internal UI and used in tokens in CFG files (emu\input.cpp and emu\inputdev.cpp).
    . Reworked and expanded documentation on configuring stable controller IDs (docs\source\advanced\ctrlr_config.rst and devicemap.rst)
  . LUA engine: Added low-level palette objects. Added indexed bitmap types. Added a bitmap method for extracting pixels from a rectangular area as a packed binary string. Changed screen device pixels method to return width and height in addition to the pixels.
  . PLUGINS: Resort hiscore.dat and set changes (plugins\hiscore\hiscore.dat)
  . Multi-Language
    . There's a menu item for copying a device ID to the clipboard and associated success/failure messages. There's the menu item for setting the software list file search path. One of the lines in the software selection menu heading has changes as it could be interpreted as implying it showed a software list name.
    . Updated Chinese, Greek and Ukrainian UI translations
  . Renamed add_scheduling_quantum to add_quantum and added perfect_quatum and use that for most cases of boost_interleave (emu\schedule.cpp)
  . Validate slot cards only once per device type during 'quick' validation passes, which were taking rather long for some drivers (e.g. (MESS) at.cpp) (emu\validity.cpp)
  . Fixed the version of utf8_from_uchar that returns std::string blowing up on invalid codepoints (util\unicode.cpp)
  . Changed core_stricmp to take std::string_view parameters (util\corestr.cpp). Note that the implementation is still not UTF-8 aware.
  . Made error messages more detailed when opening a configuration file fails and bumped error messages to warning level (emu\config.cpp). Preserve elements with no registered handlers in default and system configuation files (emu\config.cpp).
  . Consolidated drivers in single files. Minor cleanups (aeroboto.cpp, airbustr.cpp, bankp.cpp, battlex.cpp, blmbycar.cpp, djboy.cpp, drmicro.cpp, espial.cpp, exerion.cpp, fcombat.cpp, funkybee.cpp, galastrm.cpp, gatron.cpp, ginganin.cpp, glass.cpp, gomoku.cpp, groundfx.cpp, gunbustr.cpp, homerun.cpp, marineb.cpp, mcatadv.cpp, mjkjidai.cpp, momoko.cpp, mrflea.cpp, msisaac.cpp, oneshot.cpp, pirates.cpp, pitnrun.cpp, retofinv.cpp, rollrace.cpp, sbugger.cpp, skyfox.cpp, ssrj.cpp, targeth.cpp, thief.cpp, thoop2.cpp, vastar.cpp, volfied.cpp, warriorb.cpp, wiping.cpp, wrally.cpp, xorworld.cpp and zodiack.cpp)
- MAC OS X: Full dark mode support for macOS 10.14 and later. Raise requirement for Dark Mode to 10.15.
- Compiling
  . Ignore all but type 0x20 symbols (osd\modules\diagnostics\diagnostics_win32.cpp)
  . Fixes for Clang 15.0 on Windows
  . Removed not strictly needed use of strrchr (util\plaparse.cpp)
  . Updated build prerequisite package names for newer Ubuntu versions (initialsetup\compilingmame.rst)
- Debugger
  . Added exception points as a new class of "points" triggering on specific exception numbers, with a similar set of commands to breakpoints and registerpoints. Removed the per-instruction callback hook from device_debug. Only one driver was using this (rmnimbus.cpp), and what it was doing with it could be done more cleanly with exception points. Changed the type of the action string parameter for "points"-creating methods and make some parameters optional for those. Changed trace file logging to use a std::ostream instead of FILE * to take better advantage of strformat.
  . Capture big objects by reference in lambdas (tools\unidasm.cpp)
  . Reallow debugger single-step command to break into subroutines during over/out stepping (debug\debugcpu.cpp)
  . Added capability to save/restore window arrangement. Format is mostly compatible with the Cocoa debugger, besides reversed vertical positioning.
  . Made Qt debugger more compatible with configuration format used by Win32 and Cocoa debuggers. Added a crude dark theme for the Win32 debugger.
  . Made a start on weaning the Qt debugger off its weird configuation objects. It can now save more view state with less string comparisons on memory labels, but it can't restore all of it yet.
  . Made closing the Qt debugger console window hide all debugger windows and run the emulated machine (debugger windows will be shown on next user break or breakpoint hit). This matches the behaviour of the Win32 and Cocoa debuggers. Made Qt debugger clean up its windows on exit rather than on subsequent starts. This fixes GitHub #9789. Made Qt debugger less reliant on global variables, and made code to save and load configuration a bit less convoluted. It still needs more refactoring on this front, but it's in slightly better shape now. Made Qt debugger a bit less crashy on invalid configuration. Still plenty of ways to crash it, but every little bit counts. Made Qt debugger do less comparisons on menu item names and object names - it might be possible to localise one day. Moved all the C++ debugger implementations into namespaces. They're using awfully generic class names, so it's about time.
  . Don't try closing windows if debugger console wasn't created (debugger\debugqt.cpp)
  . Use swapendian_int* (debugger\debuggdbstub.cpp)
  . Added debugger exception hook calls (cpu\h8\h8.lst and cpu\sh\sh2.cpp)