MAMEWorld >> EmuChat
View all threads Index   Flat Mode Flat  

MooglyGuy
Renegade MAME Dev
Reged: 09/01/05
Posts: 2261
Send PM
Re: Submitting driver to github?
04/11/19 08:48 PM


> If Git is too much trouble, we have been known to accept code and/or data via email
> mentioned here:
> https://wiki.mamedev.org/index.php/Submitting_Source_Code
>
> All code is subject to critique and revision, as you probably know, you should do as
> much as you can to make sure your code compiles cleanly against the current Git
> sources provided at: https://github.com/mamedev/mame
>
> You'll need ROM_LOADs to be logically worked out, if possible, to CPU/SOUND/VIDEO/ETC
> and each machine should be accessible to launch via MAME provided you have the
> romsets listed and not crash or hang the emulator. This means providing all the hooks
> needed to make your entries be recognized by the build system such as the .lst and
> .flt files in src\mame as well as appropriate .lua files in scripts\target\mame.

Please don't encourage people to submit drivers via loose files. Making a pull request is straightforward and doesn't create a major pain in the ass for the devs like loose files do.

TrevEB, I would encourage you to Google for "github pull request", minus the quotes, and start there. The very first link should be a page on Github's own Help page entitled "About pull requests", which explains pretty much exactly how to go about creating and submitting a pull request. You seem to be under the mistaken notion that MAME requires some sort of special procedure for submitting changes, when in reality submitting pull requests is how a huge number of open-source projects operate.







Entire thread
Subject Posted by Posted on
* Submitting driver to github? TrevEB 04/11/19 07:10 PM
. * Re: Submitting driver to github? Vas Crabb  04/29/19 09:21 AM
. * Re: Submitting driver to github? TrevEB  04/30/19 08:27 AM
. * Re: Submitting driver to github? Vas Crabb  04/30/19 03:20 PM
. * Re: Submitting driver to github? TrevEB  04/30/19 07:11 PM
. * Re: Submitting driver to github? gregf  04/29/19 10:59 AM
. * Re: Submitting driver to github? Vas Crabb  04/12/19 02:25 AM
. * Re: Submitting driver to github? TafoidAdministrator  04/11/19 08:09 PM
. * Re: Submitting driver to github? MooglyGuy  04/11/19 08:48 PM
. * Re: Submitting driver to github? TrevEB  04/12/19 02:51 AM
. * Re: Submitting driver to github? Vas Crabb  04/12/19 03:44 AM
. * Re: Submitting driver to github? Hydreigon  04/12/19 04:22 PM
. * Re: Submitting driver to github? TrevEB  04/16/19 05:05 PM
. * Re: Submitting driver to github? ICEknight  04/19/19 12:23 AM
. * Re: Submitting driver to github? Mr. DoAdministrator  04/19/19 08:03 AM
. * Re: Submitting driver to github? amoroboshi116  04/20/19 10:23 AM
. * Star Rider etc. *edited again* gregf  04/20/19 10:08 PM
. * Re: Star Rider etc. *edit* italiandoh  04/21/19 04:41 PM
. * Re: Star Rider gregf  04/29/19 11:10 AM
. * Re: Star Rider Matt Ownby  04/29/19 11:10 PM
. * Re: Star Rider amoroboshi116  05/02/19 05:09 AM
. * Re: Star Rider Matt Ownby  07/16/19 06:43 PM
. * Re: Star Rider TrevEB  05/01/19 04:32 AM
. * Re: Star Rider etc. *edit* amoroboshi116  04/27/19 03:22 AM
. * Re: Star Rider etc. *edit* Vas Crabb  04/27/19 03:52 AM
. * Re: Star Rider etc. *edit* AaronGiles  04/30/19 06:21 PM
. * Re: Star Rider etc. *edit* Vas Crabb  04/30/19 06:33 PM
. * Re: Star Rider etc. *edit* AaronGiles  04/30/19 06:49 PM
. * Re: Star Rider etc. *edit* amoroboshi116  04/27/19 02:42 PM
. * Re: Star Rider etc. *edit* R. Belmont  04/28/19 03:14 PM

Extra information Permissions
Moderator:  Robbbert, Tafoid 
0 registered and 251 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 1795