MAMEWorld >> EmuChat
Previous thread Previous  View all threads Index   Next thread Next   Flat Mode Flat  

AaronGiles
Galaxiwarrior
Reged: 09/21/03
Posts: 1343
Send PM
Re: bug: chdman output depends on system qsort() implementation
06/17/12 02:09 AM


> > I expect that on Windows, qsort() is not stable and the output will change. Could
> you
> > please check if you have time?
>
> Thanks, that patch looks very reasonable. Let me know what you find out regarding the
> other issue.

Right, good find. The simplest fix as you mention is to ensure that we never return "equal" from the qsort callback.

Fortunately, no matter the ordering, all CHDs produced the existing "bad" way should be readable by all other implementations. But we should make sure we always generate the same output regardless. Thanks for digging into it.







Entire thread
Subject Posted by Posted on
* bug: chdman output depends on system qsort() implementation jmak 06/16/12 12:55 PM
. * Re: bug: chdman output depends on system qsort() implementation R. Belmont  06/16/12 03:56 PM
. * Re: bug: chdman output depends on system qsort() implementation krick  06/16/12 04:16 PM
. * Re: bug: chdman output depends on system qsort() implementation R. Belmont  06/16/12 05:50 PM
. * Re: bug: chdman output depends on system qsort() implementation krick  06/16/12 06:28 PM
. * Re: bug: chdman output depends on system qsort() implementation R. Belmont  06/16/12 06:39 PM
. * Re: bug: chdman output depends on system qsort() implementation italieAdministrator  06/16/12 08:38 PM
. * Re: bug: chdman output depends on system qsort() implementation jmak  06/16/12 08:22 PM
. * Re: bug: chdman output depends on system qsort() implementation krick  06/17/12 07:38 PM
. * Re: bug: chdman output depends on system qsort() implementation jmak  06/17/12 07:44 PM
. * Re: bug: chdman output depends on system qsort() implementation R. Belmont  06/17/12 10:13 PM
. * Re: bug: chdman output depends on system qsort() implementation AaronGiles  06/17/12 11:37 PM
. * Re: bug: chdman output depends on system qsort() implementation krick  06/18/12 04:08 AM
. * Re: bug: chdman output depends on system qsort() implementation R. Belmont  06/16/12 10:13 PM
. * Re: bug: chdman output depends on system qsort() implementation jmak  06/17/12 06:47 PM
. * Re: bug: chdman output depends on system qsort() implementation jmak  06/17/12 06:58 PM
. * Re: bug: chdman output depends on system qsort() implementation R. Belmont  06/17/12 10:00 PM
. * Re: bug: chdman output depends on system qsort() implementation jmak  06/19/12 09:30 PM
. * Re: bug: chdman output depends on system qsort() implementation AaronGiles  06/17/12 02:09 AM
. * Re: bug: chdman output depends on system qsort() implementation TafoidAdministrator  06/16/12 09:06 PM
. * Re: bug: chdman output depends on system qsort() implementation krick  06/16/12 08:10 PM
. * Re: bug: chdman output depends on system qsort() implementation jmak  06/16/12 08:33 PM

Extra information Permissions
Moderator:  Robbbert, Tafoid 
0 registered and 700 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 2178