Entrance | Main Index | Search | New user | Login | Who's Online | FAQ | Rules

MAMEWorld >> EmuChat
Previous thread Previous  View all threads Index   Next thread Next   Flat Mode Flat  

Bryan Ischo
MAME Fan
Reged: 03/28/10
Posts: 358
Send PM
Re: Cppcheck a tool for MAME C/C++ code analysis :)
10/12/11 02:04 AM
Reply to this post Reply


You really need to say exactly what version of MAME you ran that tool against.

For example, I looked at the warning for emu/addrmap.c and the m_submap_bits field doesn't even exist in address_map_entry in the version I have, which is MAME 0.143.

The 'information' and 'style' 'Schweregrad' entries (whatever that is) are totally irrelevant.

The warnings for emu/drawgfx.h do look serious but I have a feeling that the class in question is only ever created via a new operator which zeroes memory. I don't know for sure but it feels like it would be very MAME-like to have every C++ constructor invoke a version of new that used calloc. Someone else would have to validate this though as I don't have the time at this exact moment to look that up.






Entire thread
Subject Posted by Posted on
* Cppcheck a tool for MAME C/C++ code analysis :) MASH 10/12/11 12:47 AM
. * Re: Cppcheck a tool for MAME C/C++ code analysis :) Bryan Ischo  10/12/11 02:04 AM
. * Re: Cppcheck a tool for MAME C/C++ code analysis :) R. Belmont  10/12/11 02:56 AM
. * Re: Cppcheck a tool for MAME C/C++ code analysis :) redk9258  10/12/11 02:35 AM

Extra information Permissions
Moderator:  Robbbert, Tafoid 
0 registered and 353 anonymous users are browsing this forum. 		You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 1740


Browser Test | Delete Cookies atom-guru atom-guru *
UBB.threads™ 6.3.2