MAMEWorld >> EmuChat
Previous thread Previous  View all threads Index   Next thread Next   Flat Mode Flat  

ShimaPong
MAME Fan
Reged: 03/12/05
Posts: 783
Send PM
Re: Debugger command 'symlist' bugs
11/26/10 03:30 PM Attachment: bygone.png 18 KB (0 downloads)


Simple solution is that add "if (strlen(string) > 1)" to tagmap_hash().

Code:


INLINE UINT32 tagmap_hash(const char *string)
{
UINT32 hash = (string[0] << 5) + string[1];
char c;

if (strlen(string) > 1)
string += 2;

while ((c = *string++) != 0)
hash = ((hash << 5) | (hash >> 27)) + c;
return hash;
}


OK, symlist command doesn't cause the crash and do command recognizes 8-bit registers.
But I think it's better to add "length" variable into tagmap_entry then read it directly instead of using strlen() in tagmap_hash(). (It's complete my error!)


BTW, GFX viewer crashes when you select "TMAP" section in bygone with multithreading = 1. Someone confirmed?
This option is demon's gate for me because internal debugger freezes and ktiger/twincobr crashes at boot though...

[ATTACHED IMAGE - CLICK FOR FULL SIZE]

Attachment


"Any company has no power to stop people emulating"
MAME is the emulator of no giving in the pressure from any company even if they don't allow

Edited by ShimaPong (11/28/10 04:21 PM)







Entire thread
Subject Posted by Posted on
* Debugger command 'symlist' bugs ShimaPong 11/25/10 03:16 PM
. * Re: Debugger command 'symlist' bugs ShimaPong  11/28/10 04:23 PM
. * Re: Debugger command 'symlist' bugs CrapBoardSoftware  11/28/10 09:16 PM
. * Re: Debugger command 'symlist' bugs ShimaPong  11/27/10 03:47 PM
. * Re: Debugger command 'symlist' bugs ShimaPong  11/26/10 03:30 PM
. * Re: Debugger command 'symlist' bugs pepinos  11/26/10 05:07 PM
. * Re: Debugger command 'symlist' bugs CrapBoardSoftware  11/26/10 07:50 PM

Extra information Permissions
Moderator:  Robbbert, Tafoid 
0 registered and 458 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 2192