> Before submiting my changes to the dev team, I'd like to check some arbitrary choices > I made... > > 1. driver name > Game is named "Space Ship", and I choose "spaceshi" as driver name. Everybody is > happy with it ?
I'd choose spaceshp personally - it's a matter of taste.
> 2. file names in .zip file > I tried to follow Sega games naming convention in Mame. > I used "sega_reference_for_prom DOT chip_number_on_pcb". > On the Space Ship PCB, Sega uses a single "chip counter" to identify chips (IC1 to > IC140) ; on more recent PCB, Sega uses "line/column" locating convention. > It gives : > pr03.85 <= chip labelled "PR03" by Sega, located at "IC85" on PCB > pr17.138 <= chip labelled "PR17" by Sega, located at "IC138" on PCB > I noticed that later Sega will use "EPR-xxxx" (with a "-") but there's not "-" sign > on Space Ship PROMs (except two of them)
That's fine.
> 3. Mame-"useless" CCPU PROM dumps > There are 6 PROMs used only for internal CCPU control. > They are useless for Mame. > Should them be referenced by the driver ? > I think "yes", because it is done in this way for spacewar. > > 4. Redundant CCPU PROM dumps > 5 of the 6 PROMs for CCPU internal control are exact bit-to-bit copy of > Cinematronic's PROMs for CCPU. > Only chip reference (on Sega naming convention and on PCB) are different. > Should these 5 files be in the .zip file ? > One Sega CCPU PROM is different from Cinematronic. > I'm sure it is not a dump error, neither a partialy dead chip. > Differences are in bits that don't affect CCPU behavior. > For example, while reading an input, Sega does not select some chips just before the > ALU heart of the CCPU. > Should this file be present in the .zip ?
Yes, include all the PROMs in the .zip
|