MAMEWorld >> EmuChat
View all threads Index   Threaded Mode Threaded  

Pages: 1

Traso
MAME Fan
Reged: 01/15/13
Posts: 2687
Send PM


HLSL makes colors wonky
#355961 - 06/26/16 03:56 AM


I first noticed this in Joust, where things are uber-red. A similar effect happens in Donkey Kong. Purple girders are less so, and red seems to be an overlaying hue. Further, the display field is oversaturated, as if the brightness were turned up a little much, but this is stock. Altering display settings doesn't change these effects.

The bizarrest thing is the site 500 craps when I try to upload the image - so I've had to host and paste.....






Scifi frauds. SF illuminates.
_________________

Culture General Contact Unit (Eccentric)



B2K24
MAME @ 15 kHz Sony Trinitron CRT user
Reged: 10/25/10
Posts: 2663
Send PM


Re: HLSL makes colors wonky new [Re: Traso]
#355964 - 06/26/16 07:40 AM


Post needs more specific information if you expect help or input of any kind.

Your screen shot doesn't show wonky colors.



Traso
MAME Fan
Reged: 01/15/13
Posts: 2687
Send PM


Assume I'm using current baseline..... new [Re: B2K24]
#355965 - 06/26/16 08:19 AM


with stock settings. What else you want to know? Not that it should matter, cos these look different.









Scifi frauds. SF illuminates.
_________________

Culture General Contact Unit (Eccentric)



SoltanGris42
MAME Fan
Reged: 11/16/13
Posts: 134
Send PM


Re: Assume I'm using current baseline..... new [Re: Traso]
#355966 - 06/26/16 09:00 AM


> with stock settings. What else you want to know? Not that it should matter, cos these
> look different.

Color shifts like that are usually from either gamma settings or from clipping when the saturation is turned up.

Check the following sliders: Signal Exponent, Saturation, and gamma. Only the first two are from hlsl. Gamma is a regular MAME thing. But any of those can move the colors in the direction shown in you screenshots.

The default hlsl settings have never been great. You need to adjust them to taste and then edit the chain file to match your preferred settings.



B2K24
MAME @ 15 kHz Sony Trinitron CRT user
Reged: 10/25/10
Posts: 2663
Send PM


Re: Assume I'm using current baseline..... new [Re: Traso]
#355968 - 06/26/16 09:13 AM


This is why I've mainly moved to BGFX with an edited hlsl.json to values I enjoy looking at while playing.

replace all from line 58 to 118

http://pastebin.com/McBdKSqY



Jezze
Reged: 03/14/05
Posts: 72
Send PM


Re: Assume I'm using current baseline..... new [Re: Traso]
#355969 - 06/26/16 09:21 AM


The HLSL chain for BGFX does nothing else. It's all a matter of configuration you can read about here.

Just reset the color ratios to their default settings.



anikom15
Instigator/Local CRT Guru
Reged: 04/11/16
Posts: 287
Send PM


Re: HLSL makes colors wonky new [Re: Traso]
#355980 - 06/26/16 05:39 PM


The default raster preset actually changes the color ratios. I don't know why, maybe to demonstrate the effect.



SoltanGris42
MAME Fan
Reged: 11/16/13
Posts: 134
Send PM


Re: HLSL makes colors wonky new [Re: anikom15]
#355981 - 06/26/16 07:22 PM


> The default raster preset actually changes the color ratios. I don't know why, maybe
> to demonstrate the effect.

I think they're back to normal in git?

I don't know how long they were set weird. There is an argument for having them different though. Since arcade monitors were usually 9300k and our modern hdtv standards are 6500k, but it's probably not a great idea to do try to adjust the color temp in the shader. You'll lose a lot of brightness and everything will look wrong when you start up a game at 9300k. Also, since arcade monitors have pots to adjust levels, white balance was probably all over the place all the time.



Traso
MAME Fan
Reged: 01/15/13
Posts: 2687
Send PM


Re: HLSL makes colors wonky new [Re: SoltanGris42]
#356001 - 06/27/16 11:27 PM


> I don't know how long they were set weird. There is an argument for having them different though. Since arcade monitors were usually 9300k and our modern hdtv standards are 6500k, but it's probably not a great idea to do try to adjust the color temp in the shader. You'll lose a lot of brightness and everything will look wrong when you start up a game at 9300k. Also, since arcade monitors have pots to adjust levels, white balance was probably all over the place all the time.



I've read it's the other way: old tubes designs were lower color temp, and PC monitors were higher. All the PC CRTs I've had default at 9300. Sometimes I've put it at 6500, but not with current MAME. The months-new LED backlit LCD TV on my main PC rig doesn't have color temp, but instead color schemes: normal (which looks like 9300), warm (which looks like 6500), and cool (which is blue-heavy or red-missing). My theatre rig plasma is similar.

Anyways, general color palette had changed some over time, and sometimes weirdly, but never so strongly as it has into .174 . I understand the enthusiasm to make an 'authentic' type of image in the default settings, but the settings should change to reflect this, not as it seems hard-coded, and then try to adjust.



Scifi frauds. SF illuminates.
_________________

Culture General Contact Unit (Eccentric)



Nightvoice
MAME Fan
Reged: 03/19/10
Posts: 883
Loc: The Room Next To You
Send PM


Re: Assume I'm using current baseline..... new [Re: SoltanGris42]
#356004 - 06/27/16 11:46 PM


> Check the following sliders: Signal Exponent, Saturation, and gamma. Only the first
> two are from hlsl. Gamma is a regular MAME thing. But any of those can move the
> colors in the direction shown in you screenshots.
>

I made the observation that there's a bug in HLSL saturation whereby you can use the slider control to set it really high (which looks great on some Atari 2600 games), but it won't save and if you try to edit the ini file it won't take anything higher than 4 without erroring.



----------------------
I have officially retired from sucking at everything I do. Life is much easier now.

My MAME/MESS artwork files: https://drive.google.com/open?id=1ABxeKgNIrKlIsyck7dx4V241NFQDWAF4
Related screen shots: https://drive.google.com/open?id=1U5IbvbVzYW97PuOOQuocvZFE_YJz7WIn



Traso
MAME Fan
Reged: 01/15/13
Posts: 2687
Send PM


Re: Assume I'm using current baseline..... new [Re: Jezze]
#356011 - 06/28/16 07:34 AM


> Just reset the color ratios to their default settings.


They are default. I changed them to try to make it more normal, then changed them back for the images shown.



Scifi frauds. SF illuminates.
_________________

Culture General Contact Unit (Eccentric)



Jezze
Reged: 03/14/05
Posts: 72
Send PM


Re: Assume I'm using current baseline..... new [Re: Traso]
#356016 - 06/28/16 02:43 PM


Okay, it's not only the color ratio. But if you reset all color settings to their defaults, then you should get the result you expect.


Code:

red_ratio                 1.0,0.0,0.0
grn_ratio 0.0,1.0,0.0
blu_ratio 0.0,0.0,1.0
saturation 1.0
offset 0.0,0.0,0.0
scale 1.0,1.0,1.0
power 1.0,1.0,1.0
floor 0.0,0.0,0.0




Traso
MAME Fan
Reged: 01/15/13
Posts: 2687
Send PM


Re: Assume I'm using current baseline..... new [Re: Jezze]
#356054 - 06/29/16 07:49 AM


> Okay, it's not only the color ratio. But if you reset all color settings to their
> defaults, then you should get the result you expect.
>
> red_ratio 1.0,0.0,0.0
> grn_ratio 0.0,1.0,0.0
> blu_ratio 0.0,0.0,1.0
> saturation 1.0
> offset 0.0,0.0,0.0
> scale 1.0,1.0,1.0
> power 1.0,1.0,1.0
> floor 0.0,0.0,0.0


They are like that. Ohhhhh, in raster.ini . I'm not sure that fixed anything - however, it got rid of the scanline effect...and setting back to 50 doesn't look quite right, but 1 is too much. Hmmmm.....

In any case, before all that: I found setting signal scale (all three) to 1.0 gets the colors back mostly to normal. THEN setting signal floors to 0 gets rid of the S-video-like background. Still a little oversaturated in something, but it's much better.

The site is eating fucking dick again, and 500 crapping when I try to upload an image. Smitty.....




Scifi frauds. SF illuminates.
_________________

Culture General Contact Unit (Eccentric)



Traso
MAME Fan
Reged: 01/15/13
Posts: 2687
Send PM


Effect continues with .175 new [Re: Traso]
#356174 - 07/03/16 12:09 AM


Must be few people are playing DK. The S-video-like background, about half the ugliness of the Radarscope mode, people must not be noticing because they're condition-blinded by LCD backlighting.

Anyways, I filed a report. Hopefully it'll get fixed, cos I like HLSL stock.



Scifi frauds. SF illuminates.
_________________

Culture General Contact Unit (Eccentric)


Pages: 1

MAMEWorld >> EmuChat
View all threads Index   Threaded Mode Threaded  

Extra information Permissions
Moderator:  Robbbert, Tafoid 
0 registered and 297 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 2600