|
No more sounds in wiz
#272362 - 01/07/12 02:11 AM
|
|
|
Please replace the line:
device_set_input_line (device, 0, HOLD_LINE);
with:
device_set_input_line (device, INPUT_LINE_NMI, PULSE_LINE);
in sound_timer_irq.
|
|
|
Stiletto |
|
They're always after me Lucky ROMS!
|
|
|
|
|
|
Reged: 03/07/04
|
|
Posts: 6472
|
|
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: darq]
#272364 - 01/07/12 02:54 AM
|
|
|
> Please replace the line:
> device_set_input_line (device, 0, HOLD_LINE);
>
> with:
> device_set_input_line (device, INPUT_LINE_NMI, PULSE_LINE);
>
> in sound_timer_irq.
I keep worrying that no one sees your bugfixes.
I'll let people know, but can you please register and post at MAMETesters?
http://www.mametesters.org
Thanks.
- Stiletto
|
|
|
| Tafoid |
|
I keep on testing.. testing.. testing... into the future!
|
|
|
|
|
Reged: 04/19/06
|
|
Posts: 3137
|
|
Loc: USA
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: Stiletto]
#272365 - 01/07/12 02:59 AM
|
|
|
> > Please replace the line:
> > device_set_input_line (device, 0, HOLD_LINE);
> >
> > with:
> > device_set_input_line (device, INPUT_LINE_NMI, PULSE_LINE);
> >
> > in sound_timer_irq.
>
> I keep worrying that no one sees your bugfixes.
>
> I'll let people know, but can you please register and post at MAMETesters?
> http://www.mametesters.org
>
> Thanks.
>
> - Stiletto
I'll take care of this. Thank you.
|
|
|
|
Re: No more sounds in wiz
[Re: Stiletto]
#272369 - 01/07/12 04:19 AM
|
|
|
> > Please replace the line:
> > device_set_input_line (device, 0, HOLD_LINE);
> >
> > with:
> > device_set_input_line (device, INPUT_LINE_NMI, PULSE_LINE);
> >
> > in sound_timer_irq.
>
> I keep worrying that no one sees your bugfixes.
>
> I'll let people know, but can you please register and post at MAMETesters?
> http://www.mametesters.org
>
> Thanks.
>
> - Stiletto
Ok I will, if I find other bugs, I will post on mametester  , but no developers, read this forum?
|
|
|
| Naoki |
|
|
|
|
|
|
Reged: 11/10/09
|
|
Posts: 1998
|
|
Loc: United Kingdom
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: darq]
#272389 - 01/07/12 12:13 PM
|
|
|
They do, but then I think posting it to MAME Testers is easier for them
|
----
On a quest for Digital 573 and Dancing Stage EuroMix 2
By gods I've found it!
|
|
|
Re: No more sounds in wiz
[Re: darq]
#272393 - 01/07/12 05:14 PM
|
|
|
Thanks, it should be fixed in the next MAME update.
Yes, we prefer MT(mametesters.org) for bugs. If it wasn't for Tafoid forwarding this bug to MT, good chance it would, to put it bluntly, be ignored.
|
|
|
| Stiletto |
|
They're always after me Lucky ROMS!
|
|
|
|
|
|
Reged: 03/07/04
|
|
Posts: 6472
|
|
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: darq]
#272472 - 01/08/12 07:42 PM
|
|
|
> Ok I will, if I find other bugs, I will post on mametester , but no developers, read
> this forum?
There's a bad noise-to-signal ratio on this board. If a message like this goes without any replies, developers might not even read this message. Others of yours have been missed before.
And also remember: this is an "unofficial" MAME forum, and not all developers come here. All active developers check out MAMETesters and while still unofficial (I guess?) it's much closer to being "official" for bug reports than anything else.
- Stiletto
|
|
|
| B2K24 |
|
MAME @ 15 kHz Sony Trinitron CRT user
|
|
|
|
|
Reged: 10/25/10
|
|
Posts: 2663
|
|
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: hap]
#272475 - 01/08/12 08:46 PM
|
|
|
> Yes, we prefer MT(mametesters.org) for bugs. If it wasn't for Tafoid forwarding this
> bug to MT, good chance it would, to put it bluntly, be ignored.
Yeah, it's always good to discuss it here too see if other people can confirm it. Then a proper bug report should be filed once it's confirmed.
|
|
|
|
Re: No more sounds in wiz
[Re: B2K24]
#272549 - 01/09/12 10:34 AM
|
|
|
> > Yes, we prefer MT(mametesters.org) for bugs. If it wasn't for Tafoid forwarding
> this
> > bug to MT, good chance it would, to put it bluntly, be ignored.
>
> Yeah, it's always good to discuss it here too see if other people can confirm it.
> Then a proper bug report should be filed once it's confirmed.
In fact I posted here exactly to discuss the validity of my stupid things :-D, or at least I hoped so  , however I understand Stiletto's point.
|
|
|
| R. Belmont |
|
Cuckoo for IGAvania
|
|
|
|
|
|
Reged: 09/21/03
|
|
Posts: 9716
|
|
Loc: ECV-197 The Orville
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: darq]
#272564 - 01/09/12 06:10 PM
|
|
|
> In fact I posted here exactly to discuss the validity of my stupid things :-D, or at
> least I hoped so , however I understand Stiletto's point.
For reference, PULSE_LINE is almost always wrong (no hardware behaves that way), and needing it generally means there's an unmapped read/write somewhere that actually CLEAR_LINE's the interrupt. For sound latches, reading the latch frequently also clears the interrupt.
|
|
|
|
Re: No more sounds in wiz
[Re: R. Belmont]
#272575 - 01/09/12 09:46 PM
|
|
|
Thank you for your explanation, but I didn't understand if you are talking about use of PULSE_LINE in general,
or are you referring to my fix.
Is there a better fix without using PULSE_LINE with NMIs?
|
|
|
| R. Belmont |
|
Cuckoo for IGAvania
|
|
|
|
|
|
Reged: 09/21/03
|
|
Posts: 9716
|
|
Loc: ECV-197 The Orville
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: darq]
#272581 - 01/09/12 11:20 PM
|
|
|
> Thank you for your explanation, but I didn't understand if you are talking about use
> of PULSE_LINE in general,
> or are you referring to my fix.
Both. It's incorrect in general, *and* your fix is incorrect for the same reason.
> Is there a better fix without using PULSE_LINE with NMIs?
Yes. Look for an unhandled/unmapped read or write which happens in the NMI handler. Hook that up so it does a CLEAR_LINE on the NMI and change the timer to ASSERT_LINE instead of PULSE_LINE.
|
|
|
|
Re: No more sounds in wiz
[Re: R. Belmont]
#272584 - 01/10/12 12:06 AM
|
|
|
> For reference, PULSE_LINE is almost always wrong (no hardware behaves that way), and
> needing it generally means there's an unmapped read/write somewhere that actually
> CLEAR_LINE's the interrupt. For sound latches, reading the latch frequently also
> clears the interrupt.
huh? PULSE_LINE is not unusual, it's for edge triggered interrupts. IMO the almost-always-wrong type in MAME is HOLD_LINE.
|
|
|
|
Re: No more sounds in wiz
[Re: hap]
#272585 - 01/10/12 12:31 AM
|
|
|
Hi hap, I finished right now to search into existing drivers... maybe is more correct what rbelmont says, but it seems that 98% of drivers use the 'syntax' (INPUT_LINE_NMI, PULSE_LINE) : )
@rbelmont: Did you meant something like psikyo.c driver (psikyo_soundlatch_callback) ?
If not, can you provide me a 'reference' driver?
|
|
|
| R. Belmont |
|
Cuckoo for IGAvania
|
|
|
|
|
|
Reged: 09/21/03
|
|
Posts: 9716
|
|
Loc: ECV-197 The Orville
|
|
|
|
Send PM
|
|
|
Re: No more sounds in wiz
[Re: hap]
#272657 - 01/10/12 07:52 PM
|
|
|
> huh? PULSE_LINE is not unusual, it's for edge triggered interrupts. IMO the
> almost-always-wrong type in MAME is HOLD_LINE.
Even for CPUs with edge-triggered interrupts, circuits that pulse the IRQ line are pretty rare (it's extra gates). Usually the line is only triggered by an edge in one direction so the peripheral goes low->high and that trips the CPU. Then you ack it and the line goes high->low so other sources may drive the line.
|
|
|
Index 
Threaded 
No more sounds in wiz
Reply
[Re: 
, but no developers, read this forum?
, however I understand Stiletto's point.
